potiuk commented on PR #66478: URL: https://github.com/apache/airflow/pull/66478#issuecomment-4414328235
This PR has multiple issues: * secure indicates that regular Bash Operator is not secure (it is - it just requires careful passing user input) * it uses complex logic to prevent injection - that is not protecting against all cases - so it gives false sense of security * there are **plenty** of other operators and hooks where passing parameters might cause some kinds of injection - having just one place that "possibly prevents" it - is worse than consistently relying on DagAuthors knowing what they are doing I do not think we should have it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
