potiuk opened a new pull request, #66673:
URL: https://github.com/apache/airflow/pull/66673

   `DEFAULT_SENSITIVE_FIELDS` is the allowlist used by the secrets masker for
   masking Variables and Connection extras. Several common field names used by
   official Airflow providers and standard HTTP/database configurations are
   not in the allowlist.
   
   This PR adds five field names commonly used in connection extras and
   provider configurations:
   
   - `webhook_url` — Slack provider webhook URL key
   - `bearer` — HTTP bearer-token auth key
   - `dsn` — database connection strings (which typically embed credentials, 
e.g. `postgres://user:pass@host/db`)
   - `auth_header` — custom HTTP auth header values
   - `service_key` — service-account-like keys
   
   The matcher uses case-insensitive substring matching, so e.g. `bearer` covers
   `Bearer`, `bearer_token`, `auth_bearer`, etc.
   
   Related: https://github.com/airflow-s/airflow-s/issues/377
   
   ## Test plan
   
   - [ ] `uv run --project shared/secrets_masker pytest 
shared/secrets_masker/tests/ -xvs` — secrets-masker tests pass
   - [ ] New parametrised test asserts `should_hide_value_for_key(name)` 
returns `True` for each of the five new field names plus substring variants 
(`WEBHOOK_URL`, `slack_webhook_url`, `auth_bearer`, `AUTH_HEADER`, 
`custom_auth_header`, `my_service_key`)
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Opus 4.7 (1M context)
   
   Generated-by: Claude Opus 4.7 (1M context) following the guidelines at
   
https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to