SameerMesiah97 commented on code in PR #66479:
URL: https://github.com/apache/airflow/pull/66479#discussion_r3215716103
##########
providers/alibaba/tests/unit/alibaba/cloud/hooks/test_oss.py:
##########
@@ -198,3 +198,37 @@ def test_key_exists(self, mock_get_client):
def test_get_default_region(self):
assert self.hook.get_default_region() == "mock_region"
+
+ @mock.patch(OSS_STRING.format("oss.config.load_default"))
+ def test_get_client_uses_default_endpoint(self, mock_load_default):
+ mock_config = mock.MagicMock()
+ mock_load_default.return_value = mock_config
+
+ self.hook._get_client()
+
+ assert mock_config.endpoint == f"oss-{self.hook.region}.aliyuncs.com"
+
+ @mock.patch(OSS_STRING.format("oss.config.load_default"))
+ def test_get_client_uses_custom_endpoint_from_connection(self,
mock_load_default):
+ import json as json_mod
+
+ from airflow.models import Connection
+
+ mock_config = mock.MagicMock()
+ mock_load_default.return_value = mock_config
+ custom_ep = "oss-eu-central-1-internal.aliyuncs.com"
+ self.hook.oss_conn = Connection(
+ extra=json_mod.dumps(
+ {
+ "auth_type": "AK",
+ "access_key_id": "mock_access_key_id",
+ "access_key_secret": "mock_access_key_secret",
+ "region": "mock_region",
+ "endpoint": custom_ep,
+ }
+ )
+ )
+
+ self.hook._get_client()
+
+ assert mock_config.endpoint == custom_ep
Review Comment:
This test is too heavy. You don't need to create an actual `Connection`
object to assert that the endpoint argument is being used by the hook.
Something like this would be better:
```
@mock.patch(OSS_STRING.format("oss.config.load_default"))
def test_get_client_uses_custom_endpoint_from_connection(self,
mock_load_default):
mock_config = mock.MagicMock()
mock_load_default.return_value = mock_config
custom_ep = "oss-eu-central-1-internal.aliyuncs.com"
mock_conn = mock.MagicMock()
mock_conn.extra_dejson = {"endpoint": custom_ep}
self.hook.oss_conn = mock_conn
self.hook.get_credential = mock.MagicMock()
self.hook._get_client()
assert mock_config.endpoint == custom_ep
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
