nuclearpinguin commented on a change in pull request #6929: [AIRFLOW-6373] Make airflow/utils pylint compatible URL: https://github.com/apache/airflow/pull/6929#discussion_r361725384
########## File path: scripts/ci/pylint_todo.txt ########## @@ -198,34 +198,7 @@ ./airflow/ti_deps/deps/task_concurrency_dep.py ./airflow/ti_deps/deps/trigger_rule_dep.py ./airflow/ti_deps/deps/valid_state_dep.py -./airflow/utils/asciiart.py -./airflow/utils/cli_action_loggers.py -./airflow/utils/compression.py -./airflow/utils/configuration.py -./airflow/utils/dates.py -./airflow/utils/db.py -./airflow/utils/decorators.py -./airflow/utils/email.py -./airflow/utils/file.py -./airflow/utils/helpers.py -./airflow/utils/json.py -./airflow/utils/log/es_task_handler.py -./airflow/utils/log/file_processor_handler.py -./airflow/utils/log/gcs_task_handler.py -./airflow/utils/log/logging_mixin.py -./airflow/utils/log/s3_task_handler.py -./airflow/utils/log/wasb_task_handler.py -./airflow/utils/module_loading.py -./airflow/utils/net.py -./airflow/utils/operator_helpers.py -./airflow/utils/operator_resources.py -./airflow/utils/sqlalchemy.py -./airflow/utils/state.py -./airflow/utils/tests.py -./airflow/utils/timeout.py -./airflow/utils/timezone.py -./airflow/utils/trigger_rule.py -./airflow/utils/weight_rule.py +./airflow/utils/log/colored_log.py Review comment: I have no idea why but we have cyclic import here: ``` ************* Module airflow.utils.log.colored_log airflow/utils/log/colored_log.py:1:0: R0401: Cyclic import (airflow.models -> airflow.models.baseoperator -> airflow.utils.db) (cyclic-import) airflow/utils/log/colored_log.py:1:0: R0401: Cyclic import (airflow.models.baseoperator -> airflow.utils.helpers) (cyclic-import) airflow/utils/log/colored_log.py:1:0: R0401: Cyclic import (airflow.models.baseoperator -> airflow.utils.db -> airflow.models.serialized_dag -> airflow.serialization.serialized_objects) (cyclic-import) airflow/utils/log/colored_log.py:1:0: R0401: Cyclic import (airflow.models.serialized_dag -> airflow.utils.db) (cyclic-import) airflow/utils/log/colored_log.py:1:0: R0401: Cyclic import (airflow.models -> airflow.models.taskreschedule -> airflow.utils.db) (cyclic-import) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
