nailo2c commented on PR #65511:
URL: https://github.com/apache/airflow/pull/65511#issuecomment-4418012147
> Conflict-detection regex is brittle to future uv error-message changes
(scripts/in_container/run_generate_constraints.py:809-817)
Makes sense-- I've checked that `uv` has changed the error msg style many
times (same as `ruff`), so there is silent failure risk.
Here is an idea, we can add a smoke test like below:
```python
@pytest.mark.integration
def test_conflict_auto_resolution_with_real_uv(tmp_path):
"""Smoke test: real uv with a known conflict - proves the regex
actually matches uv's current stderr format."""
build_reqs = {
"pkg_a": {"cython>=3.0,<3.1"},
"pkg_b": {"cython>=3.1.2"},
}
output_path = tmp_path / "build-constraints.txt"
_resolve_build_requirements(build_reqs, output_path, config_params=...)
assert output_path.exists()
```
Then we can detect failure through the canary run.
---
> Backward-compat claim in the PR body is slightly narrower than implemented
Already fixed in docs and PR description.
---
> Smaller observations -
`scripts/in_container/install_airflow_and_providers.py:229`
I chose `${HOME}/build-constraints.txt`.
---
> Smaller observations -
`scripts/in_container/run_generate_constraints.py:651-652`
Already added a warning log.
---
> Smaller observations - Integration coverage
Already added an E2E test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
