Prab-27 commented on PR #66694: URL: https://github.com/apache/airflow/pull/66694#issuecomment-4418085029
https://github.com/apache/airflow/blob/2c9e759c7a4620f2d7de90393fb225cc4c024ca5/task-sdk/src/airflow/sdk/execution_time/task_runner.py#L2038 this `SUPERVISOR_COMMS` already has log stored as a attribute - https://github.com/apache/airflow/blob/2c9e759c7a4620f2d7de90393fb225cc4c024ca5/task-sdk/src/airflow/sdk/execution_time/comms.py#L190 This PR removes the unnecessary passing of default arguments @amoghrajesh 1- Is my approach correct ? 2 I don't understand how this removes `airflow-core` as a dependency ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
