Pranaykarvi commented on PR #63878: URL: https://github.com/apache/airflow/pull/63878#issuecomment-4418112956
Hi @potiuk all comments addressed: 1. **Broadened catch to `OSError`** — `init_log_folder()` now catches `OSError` instead of `PermissionError`, consistent with the peer function `init_log_file()`. This covers read-only filesystem (`EROFS`), disk full (`ENOSPC`), I/O errors on flaky NFS (`EIO`), and stale NFS handles (`ESTALE`) in addition to plain permission denials. 2. **Rewrote test without `caplog`** — Replaced `test_init_log_folder_permission_error_logs_warning_and_continues` with `test_init_log_folder_does_not_raise_on_permission_error`. No log assertions — the test simply verifies no exception propagates, which is the actual load-bearing contract for CLI startup. Also reverted the header comment back to the original two-line note. 3. **Added `airflow-core/newsfragments/63878.bugfix.rst`** — Describes the user-visible impact: CLI commands crashing on startup when `base_log_folder` is on a mounted filesystem the Airflow user cannot write to. 4. **PR description updated** — Removed the third bullet about wrapping `init_log_folder()` in `configure_logging()` (dropped as redundant in a prior commit). Description now matches what actually ships. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
