Subham-KRLX commented on PR #66065: URL: https://github.com/apache/airflow/pull/66065#issuecomment-4420643924
This fixes the ES9 to ES8 regression. Before I can approve please validate that the elasticsearch es_compat_with option only accepts a major version string for example 7 8 or 9 and raise AirflowConfigException on invalid values. Do not construct the Elasticsearch client twice. Create a single instance and pass it to apply_compat_with. Make the transport wrapper accept args and kwargs and decorate it with functools.wraps so it is tolerant of different elastic_transport perform_request signatures. Add a short docs entry for es_compat_with with an [airflow.cfg](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) example and note that the transport level rewrite overrides per API header negotiation. Confirm whether a newsfragment is required. Address these and I will re check and approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
