hwang-cadent commented on PR #66564: URL: https://github.com/apache/airflow/pull/66564#issuecomment-4422510548
Thanks @potiuk! Pushed `aef737192b` addressing all your points: - Hoisted the ARG_NOT_SET check above the field-name dispatch as you suggested — much cleaner, and now it covers any future operator using NOTSET on a non-date field. - Added `test_serialize_deserialize_trigger_dag_run_with_notset_logical_date` — actual round-trip through `DagSerialization` so the serializer/deserializer symmetry is what's under test. - Parametrized the unit test (and added a non-date field to the params). - Added `66564.bugfix.rst`. PTAL when you get a chance 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
