bbovenzi commented on code in PR #66714:
URL: https://github.com/apache/airflow/pull/66714#discussion_r3228479767
##########
airflow-core/src/airflow/ui/src/components/ui/Checkbox.tsx:
##########
@@ -25,13 +25,20 @@ export type CheckboxProps = {
readonly rootRef?: React.Ref<HTMLLabelElement>;
} & ChakraCheckbox.RootProps;
+const interactiveCursorProps = {
+ _disabled: { cursor: "not-allowed" },
+ cursor: "pointer",
+};
+
export const Checkbox = React.forwardRef<HTMLInputElement,
CheckboxProps>((props, ref) => {
const { children, icon, inputProps, rootRef, ...rest } = props;
return (
- <ChakraCheckbox.Root ref={rootRef} {...rest}>
+ <ChakraCheckbox.Root {...interactiveCursorProps} ref={rootRef} {...rest}>
Review Comment:
I don't think we need these props on Root, just Control.
Therefore let's simply declare the props inline vs creating the
`interactiveCursorProps` variable
##########
airflow-core/src/airflow/ui/src/components/ui/Checkbox.test.tsx:
##########
Review Comment:
I don't think a test is necessary here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
