uranusjr commented on code in PR #66708:
URL: https://github.com/apache/airflow/pull/66708#discussion_r3231501817
##########
shared/state/src/airflow_shared/state/__init__.py:
##########
@@ -103,15 +115,25 @@ def clear(self, scope: StateScope, *, all_map_indices:
bool = False) -> None:
@abstractmethod
async def aget(self, scope: StateScope, key: str) -> str | None:
- """Async variant of get. Must handle both ``TaskScope`` and
``AssetScope``."""
+ """
+ Async variant of get. Must handle both ``TaskScope`` and
``AssetScope``.
+
+ Async methods do not take a ``session`` argument — implementations are
expected
+ to manage their own async sessions internally (e.g. via
``create_session_async``).
Review Comment:
It’s interesting we don’t let sync functions manage sessions due to
https://github.com/apache/airflow/pull/66073#discussion_r3170621792 but want
async functions to manage on their own. Wouldn’t the same reason apply to async?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
