Lee-W commented on code in PR #66463:
URL: https://github.com/apache/airflow/pull/66463#discussion_r3231626009
##########
airflow-core/src/airflow/cli/cli_config.py:
##########
@@ -2108,6 +2115,11 @@ class GroupCommand(NamedTuple):
help="Display providers",
subcommands=PROVIDERS_COMMANDS,
),
+ GroupCommand(
+ name="state-store",
+ help="Manage task and asset state storage",
Review Comment:
This is not true based on what we have now. We don't do asset state
management. We can create an issue or add a command that prints the message,
but does not yet do anything (`raise NotImplemented`, maybe?) to ensure that we
do not forget and even if we forget it still kinda make sense
##########
airflow-core/src/airflow/cli/commands/state_store_command.py:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import logging
+
+from airflow.state import get_state_backend
+from airflow.state.metastore import MetastoreStateBackend
+
+log = logging.getLogger(__name__)
+
+# Other state operations (list, get, delete per key) will be added here in the
future.
+
+
+def cleanup(args) -> None:
+ """Remove expired task state rows via the configured state backend."""
+ backend = get_state_backend()
+
+ if args.dry_run:
+ if isinstance(backend, MetastoreStateBackend):
+ summary = backend._summary_dry_run_()
+ expired = summary["expired"]
+ if not expired:
+ print("Nothing to delete.")
+ return
+ print(f"Would delete {len(expired)} task state row(s):\n")
+ for dag_id, run_id, task_id, map_index, key in expired:
+ print(
+ f" Dag {dag_id!r}, run {run_id!r}, task {task_id!r},
map_index {map_index!r}, key {key!r}"
+ )
+ else:
+ print("Custom backend configured — cannot preview rows.")
Review Comment:
If that's the case, we'd better emphasize this (only support
MetastoreStateBackend) in the doc, help text, etc.
##########
airflow-core/tests/unit/state/test_metastore.py:
##########
Review Comment:
let's also add a test for other store to ensure the message is printted and
it's a no-op
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
