ferruzzi commented on code in PR #66491:
URL: https://github.com/apache/airflow/pull/66491#discussion_r3236237630
##########
providers/common/compat/src/airflow/providers/common/compat/version_compat.py:
##########
@@ -35,6 +35,7 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
AIRFLOW_V_3_0_PLUS: bool = get_base_airflow_version_tuple() >= (3, 0, 0)
AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0)
AIRFLOW_V_3_2_PLUS: bool = get_base_airflow_version_tuple() >= (3, 2, 0)
+AIRFLOW_V_3_3_PLUS: bool = get_base_airflow_version_tuple() >= (3, 3, 0)
Review Comment:
Out of scope, no action required: I feel like I've seen this new constant
added in multiple PRs, and this list is going to get increasingly unwieldy. I
wonder if we can come up with some way to simplify or replace this gating
technique. If we keep the constants like this then perhaps part of the
release cycle should be adding the next./new flag here (ie part of releasing
3.3 would be to add the new 3.4 flag) so folks can use them right away?
But maybe a better solution is to replace all these constants with a real
simple helper like `airflow_version_at_least(3, 3)`?
##########
providers/git/pyproject.toml:
##########
@@ -60,7 +60,7 @@ requires-python = ">=3.10"
# After you modify the dependencies, and rebuild your Breeze CI image with
``breeze ci-image build``
dependencies = [
"apache-airflow>=3.0.0",
- "apache-airflow-providers-common-compat>=1.12.0",
+ "apache-airflow-providers-common-compat>=1.12.0", # use next version
Review Comment:
"use next version"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
