ashb commented on code in PR #66699:
URL: https://github.com/apache/airflow/pull/66699#discussion_r3240135632


##########
task-sdk/src/airflow/sdk/api/datamodels/_generated.py:
##########
@@ -367,6 +367,10 @@ class TaskInstanceState(str, Enum):
     DEFERRED = "deferred"
 
 
+class RetentionDays(RootModel[int]):
+    root: Annotated[int, Field(ge=0, title="Retention Days")]

Review Comment:
   It's not important in the grand scheme of things, but I'm a little bit 
surprised to see this defined as it's own type, especially given its used 
exactly once.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to