rahul-madaan commented on PR #66844:
URL: https://github.com/apache/airflow/pull/66844#issuecomment-4449925573

   > Looks good, let's maybe add some tests, even static, that would check the 
expected output, just to make sure the region extraction works, the columns do 
not change by accident etc.
   
   Skipped them initially to match convention — TrinoHook, PostgresHook, 
MySQLHook and MsSqlHook all have these same get_openlineage_* methods without 
dedicated unit tests. Adding static tests now per your request.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to