amoghrajesh commented on code in PR #66699:
URL: https://github.com/apache/airflow/pull/66699#discussion_r3241105240
##########
airflow-core/src/airflow/state/metastore.py:
##########
@@ -250,7 +240,8 @@ def _set_task_state(
if dag_run_id is None:
raise ValueError(f"No DagRun found for dag_id={scope.dag_id!r}
run_id={scope.run_id!r}")
now = timezone.utcnow()
- expires_at =
_compute_expires_at_from_provided_retention_days(retention_days, now)
+ if expires_at is None:
+ expires_at = _compute_expires_at(now)
Review Comment:
Addressed now. Removed that check, now on `BaseStateBackend.set()` /
`aset()` and all the way down through `MetastoreStateBackend`, it is done
differently.
##########
airflow-core/src/airflow/state/metastore.py:
##########
@@ -250,7 +240,8 @@ def _set_task_state(
if dag_run_id is None:
raise ValueError(f"No DagRun found for dag_id={scope.dag_id!r}
run_id={scope.run_id!r}")
now = timezone.utcnow()
- expires_at =
_compute_expires_at_from_provided_retention_days(retention_days, now)
+ if expires_at is None:
+ expires_at = _compute_expires_at(now)
Review Comment:
Check PR desc for more details now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
