SameerMesiah97 commented on code in PR #66965:
URL: https://github.com/apache/airflow/pull/66965#discussion_r3245071384


##########
providers/databricks/src/airflow/providers/databricks/triggers/databricks.py:
##########


Review Comment:
   Should we not add docstring entries for `repair_run` and `caller`?



##########
providers/databricks/tests/unit/databricks/triggers/test_databricks.py:
##########


Review Comment:
   I would add a constant called `CALLER` here and then use that in your 
tests.. I think it's okay to use the same `caller` argument for both as the 
string itself is not behaviorally important



##########
providers/databricks/src/airflow/providers/databricks/triggers/databricks.py:
##########


Review Comment:
   Same here. I think we should add a docstring entry for `caller`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to