SameerMesiah97 commented on PR #66886: URL: https://github.com/apache/airflow/pull/66886#issuecomment-4455831965
> @SameerMesiah97 thanks again for the review — pushed `38d58f8` addressing the remaining three points: > > * **Opt-out control**: added `inject_query_tags: bool = True` to both `DatabricksSqlOperator` and `DatabricksCopyIntoOperator`, documented in the operator docstrings. Defaults to `True` to preserve the observability benefit, but users can pass `inject_query_tags=False` to retain full control over `session_configuration`. > * **Test placement**: moved the query-tag tests above the OpenLineage block in `test_databricks_copy.py` and to right after `test_exec_write_gcs_parquet_output` in `test_databricks_sql.py`, so they sit closer to the core execution logic. > * **Expanded test coverage** (mirrored across both files): > > * empty / partial Airflow context (missing `dag` / `task` / `run_id`) > * empty existing `query_tags` > * escape-character values (`,`, `:`, `\`) — exercises `_escape_query_tag_value` end-to-end > * preservation of unrelated `session_configuration` keys after the merge > * fallback to `databricks_conn.extra_dejson["session_configuration"]` when `hook.session_config` is `None` > * opt-out path: `inject_query_tags=False` leaves `session_config` untouched > > Comment 1 (mapping-driven helpers) was already addressed in `732df03`. Ready for another look whenever you have a moment. Let's wait for a maintainer to trigger CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
