parkhojeong commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3246608665
##########
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##########
@@ -51,9 +51,9 @@ export const DagCard = ({ dag }: Props) => {
<HStack>
<Tooltip content={dag.description}
disabled={!Boolean(dag.description)}>
<Link asChild color="fg.info" fontWeight="bold">
- <RouterLink data-testid="dag-id" to={`/dags/${dag.dag_id}`}>
+ <ReactRouterLink data-testid="dag-id" to={`/dags/${dag.dag_id}`}>
{dag.dag_display_name}
- </RouterLink>
+ </ReactRouterLink>
</Link>
Review Comment:
Thanks for the catch
Using data-testid on either Chakra Link or React Router's RouterLink
produces the same rendered result in the existing code: `<a
data-testid="id">link</a>`.
```tsx
<Link asChild>
<RouterLink data-testid="id" > link </RouterLink>
</Link>
<Link asChild data-testid="id">
<RouterLink /> link </RouterLink>
<Link>
```
I moved data-testid to Chakra Link. What do you
think?https://github.com/apache/airflow/pull/66945/commits/dfae9f0d9e88ffc990829191d892ec870ea72810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
