olegkachur-e commented on code in PR #66917:
URL: https://github.com/apache/airflow/pull/66917#discussion_r3246920368
##########
providers/google/src/airflow/providers/google/cloud/hooks/cloud_sql.py:
##########
@@ -432,13 +441,8 @@ def _wait_for_operation_to_complete(
:param time_to_sleep: Time to sleep between active checks of the
operation results.
:return: None
"""
- service = self.get_conn()
Review Comment:
I'm not against the idea of fighting regression but it makes this method
usage really weird in other places, e.g. in trigger or in the future, since
every other method calls `self.get_conn()` internally.
I'll add the test to ensure `get_conn` being cached, I think it will help
with regression, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
