Lougarou opened a new pull request, #67076: URL: https://github.com/apache/airflow/pull/67076
`GoogleBidManagerDownloadReportOperator.execute` downloads the report into a `tempfile.NamedTemporaryFile(delete=False)` and never removes it. The unencrypted report is left in the worker's temp directory after the task finishes — and also on any failure (download error, `_set_bucket_name`, the GCS upload) before the function returns. This wraps the download/upload in `try/finally` and `os.unlink`s the temp file on both the success and the failure path. There is no behaviour change other than the temporary file no longer being left behind. Covered by two new `test_bid_manager.py` tests — `test_execute_cleans_up_temp_file` and `test_execute_cleans_up_temp_file_on_upload_failure` — which assert the temp file is gone after a successful run and after an upload failure. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes (please specify the tool below) Generated-by: Anthropic Claude (Claude Code) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
