potiuk commented on PR #66060: URL: https://github.com/apache/airflow/pull/66060#issuecomment-4475997622
@Srujan-rai This PR has been converted to **draft** because the `Core...Serialization` test suite is failing across every database backend (Postgres, MySQL, SQLite, and the LowestDeps matrix), which indicates the change has broken serialization logic — see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Core serialization tests failing on all DBs**: - `Postgres tests: core / DB-core:Postgres:14:3.10:Core...Serialization` — failure - `MySQL tests: core / DB-core:MySQL:8.0:3.10:Core...Serialization` — failure - `Sqlite tests: core / DB-core:Sqlite:3.10:Core...Serialization` — failure - `Low dep tests:core / All-core:LowestDeps:14:3.10:Core...Serialization` — failure The failure being symmetric across all DB backends means it is **not** flaky CI — the test code itself is failing against the PR's change. Likely the new `KeyError` guard interacts with how triggerer log records are serialized. Reproduce locally with: ``` breeze testing core-tests --test-types Core --backend sqlite -- -k serialization ``` See the [testing docs](https://github.com/apache/airflow/blob/main/contributing-docs/09_testing.rst). **What to do next:** - Run the serialization tests locally, fix the regression, push. - Mark the PR as "Ready for review" when CI is green. Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. No rush — take your time. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). --- _Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
