potiuk commented on PR #64938: URL: https://github.com/apache/airflow/pull/64938#issuecomment-4476071395
@alamashir This PR has been converted to **draft** because deferring the heavy Google SDK imports has broken a wide swath of provider tests — see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Provider tests failing**: 8 distinct provider-test suites are failing: - `Special tests / Pendulum2 test: providers / All-prov:Pendulum2-Postgres:14:3.10:-amazon,celer...standard` - `Special tests / Latest Boto test: providers / All-prov:LatestBoto-Postgres:14:3.10:-amazon,celer...standard` - `Low dep tests: providers / All-prov:LowestDeps:14:3.10:exasol...microsoft.win` - `Non-DB tests: providers / Non-DB-prov::3.10:-amazon,celer...standard` - `Compat 2.11.1:P3.10`, `Compat 3.0.6:P3.10`, `Compat 3.1.8:P3.10`, `Compat 3.2.1:P3.10` (provider distributions) The deferred-import change likely shifted the import-time semantics in a way the existing tests rely on (mocked top-level imports, `patch.object` targeting module-level names, or import-side-effect registration). See the [provider distributions docs](https://github.com/apache/airflow/blob/main/contributing-docs/12_provider_distributions.rst) and the [testing docs](https://github.com/apache/airflow/blob/main/contributing-docs/09_testing.rst). **What to do next:** - Reproduce one of the failing provider suites locally to identify the import-pattern that broke. - Likely fixes: keep the imports at module level for symbols the tests `patch`, or update the tests to target the new lazy-import sites. - Mark the PR as "Ready for review" when the provider suites are green again. Converting a PR to draft is **not** a rejection — the deferred-import goal is worth doing, this just needs a follow-up on the test surface. No rush. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). --- _Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
