jason810496 opened a new pull request, #67105:
URL: https://github.com/apache/airflow/pull/67105

   - depends on: https://github.com/apache/airflow/pull/67104
   - related: https://github.com/apache/airflow/issues/65281
   
   ## Why
   
   ``ElasticsearchTaskHandler.__init__`` papers over a missing 
``REMOTE_TASK_LOG`` in the user's ``[logging] logging_config_class`` module by 
self-registering as the remote task-log reader during ``dictConfig``. That 
side-effect was the only thing keeping UI log read-back working for users who 
had swapped in the ES handler via a custom logging config, and it hides the 
real contract (``REMOTE_TASK_LOG`` must be set at module scope) that the core 
PR (#67104) documents.
   
   ## How
   
   - Emit ``AirflowProviderDeprecationWarning`` from the implicit-registration 
branch in ``ElasticsearchTaskHandler.__init__``, with ``stacklevel=1`` so 
module-based deprecation filters still match through ``dictConfig``.
   - Add a logging guide under ``providers/elasticsearch/docs/logging/`` that 
shows the recommended override: set ``REMOTE_TASK_LOG = 
ElasticsearchRemoteLogIO(...)`` at module scope in the user's 
``logging_config_class`` module, plus an Airflow / provider version 
compatibility matrix for the supported configurations.
   - Add a provider-local ``conftest.py`` that suppresses the new deprecation 
warning during direct handler construction in unit tests — this mirrors the 
recommended user pattern (``REMOTE_TASK_LOG`` set at module scope) so the 
forbidden-warnings plugin does not flag handler instantiation in tests.
   - Add a changelog entry announcing the deprecation.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes, with help of Claude Code Opus 4.7 following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to