amoghrajesh commented on code in PR #66859:
URL: https://github.com/apache/airflow/pull/66859#discussion_r3265007462
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -1429,6 +1438,14 @@ def _handle_current_task_success(
stats.incr("operator_successes", tags={**stats_tags, "operator_name":
operator})
stats.incr("ti_successes", tags=stats_tags)
+ # TODO: uncomment below once https://github.com/apache/airflow/pull/66699
is merged
+ # if conf.getboolean("state_store", "clear_on_success"):
+ # log.info("Task state will be cleared by the server because
clear_on_success is enabled.")
+ #
+ # if _get_worker_state_backend() is not None:
+ # # clear the task state keys for custom state backends configured
on worker side
+ # context["task_state"].clear()
Review Comment:
I have handled it now and correct `context["task_state"].clear()` only
cleans up the worker-side custom backend (external storage like S3). The DB
reference rows are cleared server-side as part of the `SucceedTask` handling
when `clear_on_success=True`. Two separate steps by design: worker owns
external storage cleanup, server owns DB cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
