guhyunwoo opened a new pull request, #67186:
URL: https://github.com/apache/airflow/pull/67186
closes: #66101
Cron preset schedules (`@hourly`, `@daily`, `@weekly`, `@monthly`,
`@quarterly`, `@yearly`) regressed between 3.1.8 and 3.2.x — `DAG(...,
schedule="@daily")` raises `AirflowTimetableInvalid` at parse time, during
`DAG.__init__` → `self.timetable.validate()`.
The Task SDK's `CronMixin`
(`task-sdk/src/airflow/sdk/definitions/timetables/_cron.py`) hands the preset
string straight to `croniter` without expanding it. The legacy `airflow-core`
`CronMixin` still maps presets via `self._expression = cron_presets.get(cron,
cron)` before validating, but that class is now only reached through
`coerce_to_core_timetable` — user code at parse time hits the task-sdk version,
which is where the bug bites.
Expand presets on the task-sdk `CronMixin` via an `attrs` field converter so
the stored `expression` matches the legacy invariant (preset already expanded).
All four cron timetable subclasses (`CronDataIntervalTimetable`,
`CronTriggerTimetable`, `CronPartitionTimetable`,
`MultipleCronTriggerTimetable`) inherit `expression` from this mixin and pick
up the fix with no per-subclass change.
`cron_presets` is duplicated locally in task-sdk with a `# Keep in sync with
airflow.utils.dates.cron_presets` comment, to keep task-sdk self-contained
without a new cross-package import.
Regression tests in
`task-sdk/tests/task_sdk/definitions/timetables/test_cron.py` cover preset
acceptance, expansion at construction (guards against a validate-only
"simplification" reverting the fix), and rejection of genuinely invalid cron
expressions.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
