guhyunwoo opened a new pull request, #67190:
URL: https://github.com/apache/airflow/pull/67190
closes: #66067
`task.queued_duration` (legacy: `dag.<dag_id>.<task_id>.queued_duration`)
stopped being emitted in Airflow 3 regardless of executor (LocalExecutor,
CeleryExecutor, KubernetesExecutor). The companion (LocalExecutor,
CeleryExecutor, KubernetesExecutor). The companion metric
`task.scheduled_duration` still emits.
In Airflow 2 the worker emitted `task.queued_duration` from
`TaskInstance._check_and_change_state_before_execution`
(`airflow-core/src/airflow/models/taskinstance.py:1366`) on the QUEUED →
RUNNING transition. In Airflow 3 the worker no longer touches the DB directly —
it reaches RUNNING through the Execution API endpoint `PATCH
/execution/task-instances/{id}/run`
(`airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py`),
which never called `TaskInstance.emit_state_change_metric`. The companion
metric kept working because the scheduler still emits `task.scheduled_duration`
directly from `scheduler_job_runner.py:990` when it queues the TI — that path
was not affected by the worker/API split.
Emit `task.queued_duration` inline from the run endpoint on the first QUEUED
→ RUNNING transition. The legacy `TaskInstance.emit_state_change_metric` is not
reused here because the handler operates on a partial-column `Row` (not a TI
ORM instance) and the update later resets `end_date` to `None`, which would
defeat the method's "only on first try" guard for retries. Mirroring the guard
inline (`end_date is None and queued_dttm is not None`) preserves the legacy
semantics — including not emitting on retries — and uses the same tag set
(`task_id`, `dag_id`, `queue`).
Two regression tests in
`airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py`:
- `test_ti_run_emits_queued_duration_metric` — first transition emits with
the expected metric name, timing (`now - queued_dttm`), and tags.
- `test_ti_run_skips_queued_duration_metric_on_retry` — a retry (previous
attempt's `end_date` populated) does not emit, matching legacy behavior.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
