kaxil opened a new pull request, #67216:
URL: https://github.com/apache/airflow/pull/67216

   
   `RuntimeTaskInstanceProtocol` (`task-sdk/src/airflow/sdk/types.py`) had 
drifted from `RuntimeTaskInstance` 
(`task-sdk/src/airflow/sdk/execution_time/task_runner.py`). This PR realigns 
the public protocol with what the runtime implementation actually exposes.
   
   ## What changed
   
   - **Fix `get_first_reschedule_date` signature.** The protocol declared 
`(self, first_try_number)` but both the implementation and the only caller 
([`sdk/bases/sensor.py:188`](https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/bases/sensor.py#L188))
 take a `Context`. Anyone type-checking against the protocol would have been 
told the wrong shape.
   - **Broaden `xcom_pull.task_ids`** to `str | Iterable[str] | None` to match 
the implementation (was `str | list[str] | None`).
   - **Add missing public surface** present on `RuntimeTaskInstance` but absent 
from the protocol:
     - `log_url` and `mark_success_url` properties (referenced externally, e.g. 
[openlineage](https://github.com/apache/airflow/blob/main/providers/openlineage/src/airflow/providers/openlineage/utils/utils.py#L1056)
 via `getattr(ti, "log_url", None)`).
     - `render_templates(context, jinja_env)` method.
     - `is_mapped` and `rendered_map_index` fields.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to