amoghrajesh commented on code in PR #67041: URL: https://github.com/apache/airflow/pull/67041#discussion_r3271463303
########## airflow-core/src/airflow/api_fastapi/core_api/datamodels/task_state.py: ########## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from datetime import datetime + +from airflow.api_fastapi.core_api.base import BaseModel, StrictBaseModel + + +class TaskStateResponse(BaseModel): + """A single task state key/value pair with metadata.""" + + key: str + value: str + updated_at: datetime + expires_at: datetime | None + + +class TaskStateCollectionResponse(BaseModel): + """All task state entries for a task instance.""" + + task_states: list[TaskStateResponse] + total_entries: int + + +class TaskStateBody(StrictBaseModel): + """Request body for setting a task state value.""" + + value: str Review Comment: Nice catch! Added `Field(max_length=65535)` to `TaskStateBody.value` and `AssetStateBody.value` with a 64KB length to match the TEXT column size, but if someone wants to store more than that, since MEDIUMTEXT is allowed, maybe we should let them? (I am aware that this capping needs to be done for execution API too, will do in a parallel PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
