jangByeongHui opened a new pull request, #67225:
URL: https://github.com/apache/airflow/pull/67225
Fix `DockerOperator.on_kill()` to respect `auto_remove='force'` and remove
orphaned containers
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
When `auto_remove='force'` is set and a task is killed (e.g. timeout, manual
stop), `on_kill()` called `cli.stop()` but never called
`cli.remove_container()`.
This left the container running as an orphan even though the user explicitly
requested force-removal.
This PR adds a `remove_container(force=True)` call inside `on_kill()` when
`auto_remove == "force"`, matching the behaviour that already exists in the
normal execution path. `APIError` is caught and logged (not re-raised)
because
`on_kill` is best-effort — the container may already be gone by the time the
call is made.
closes: #56149
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude (claude-sonnet-4-6)
Generated-by: Claude (claude-sonnet-4-6) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
