potiuk commented on PR #65602: URL: https://github.com/apache/airflow/pull/65602#issuecomment-4500187366
I think this is a migration that should be very carefully benchmarked. How long it takes to run it on a huge database ? Will it increase the size of the database ? Will it increase time to create entries ? I am not a specialist in this part -there are other people - bit at the very least evidences of migration checks on real data should be shown. This is also unclear what should drive the decision on running it And how users should be warned they have to update the index with/without airflow running concurrently or not . I think any kind of migration of our DB should have evidence of testing it heavily on various types of deployments. Also cc: @vatsrahul1001 and @ephraimbuddy who had to deal with lots of aftermath of not well tested migrations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
