sunildataengineer commented on PR #65480: URL: https://github.com/apache/airflow/pull/65480#issuecomment-4503371349
Hi @srchilukoori 👋 Gentle bump on this — it's been just over a month since your review. I've addressed all 5 blockers and 3 minor issues you raised: - Extracted `SFTPOperation` into `constants.py` (circular import fixed) - Full type annotations added to `SFTPOperatorTrigger` - remote_host`, `concurrency`, `prefetch` forwarded through trigger + `serialize()` - Directory transfer logic extracted into `_do_transfer()` static method - Replaced `asyncio.get_event_loop()` with `get_running_loop()` - Inner imports removed from test methods - Added `serialize()` roundtrip + `run()` tests for `SFTPOperatorTrigger` Would love a re-review when you get a chance. Happy to make any further changes! 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
