paultmathew commented on code in PR #67229:
URL: https://github.com/apache/airflow/pull/67229#discussion_r3277830076
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/pod.py:
##########
@@ -123,6 +127,7 @@ def __init__(
last_log_time: DateTime | None = None,
logging_interval: int | None = None,
trigger_kwargs: dict | None = None,
+ execution_deadline: float | None = None,
Review Comment:
Done. I'd originally used `float` because that's what the precedent PRs used
(`AirbyteSyncTrigger.execution_deadline`), and `time.time()` returns float so
there's no conversion at the comparison site. But you're right that sub-second
precision isn't meaningful here since the trigger polls at `poll_interval`
(default 2s) granularity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
