Quantum0uasar commented on issue #65570:
URL: https://github.com/apache/airflow/issues/65570#issuecomment-4504401089

   Hi! I'd love to help with this refactoring effort.
   
   My understanding of the task:
   - Extract duplicated `_handle_request` handler logic from 
`ActivitySubprocess`, `CallbackSubprocess`, `TriggerRunnerSupervisor`, and 
`DagFileProcessorProcess` into shared handlers in `request_handlers.py`
   - Follow the pattern already established in 
`task-sdk/src/airflow/sdk/execution_time/request_handlers.py`
   
   I'll start by:
   1. Auditing the if/elif chains in each supervisor's `_handle_request` to 
identify common patterns
   2. Creating appropriate handler functions or a dispatch table in a shared 
module
   3. Updating the supervisors to call the shared handlers
   
   Would this be best done incrementally (one supervisor at a time) or all at 
once? Happy to open a draft PR with the first supervisor extracted to get early 
feedback!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to