shahar1 commented on code in PR #66930:
URL: https://github.com/apache/airflow/pull/66930#discussion_r3280179853
##########
providers/google/src/airflow/providers/google/suite/transfers/gcs_to_gdrive.py:
##########
@@ -88,6 +88,7 @@ class GCSToGoogleDriveOperator(BaseOperator):
"source_object",
"destination_object",
"impersonation_chain",
+ "destination_folder_id",
Review Comment:
Apologies that I wasn't clear, but I meant the PR title. The PR title
currently mentions "Change gdrive system tests", while it does other stuff as
well.
Adding to the field description is unnecessary (however - adding a
description to the PR would be very useful for reviewers).
##########
providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py:
##########
Review Comment:
It should be a part of this PR - adding `drive_id` without fixing `FOLDER_ID
= ""` silently drops the folder filter in the hook, so the test searches the
entire shared drive by name. In a system test environment the shared drive
might be shared across test runs or users, meaning stale files with the same
name could make the hook return the first match from the API in arbitrary
order, causing the test to detect or download the wrong file.
##########
providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py:
##########
@@ -73,8 +77,15 @@
start_date=datetime(2021, 1, 1),
catchup=False,
tags=["example", "gcs", "gdrive"],
+ render_template_as_native_obj=True,
Review Comment:
`render_template_as_native_obj=True` is for returning non-string types
(dicts, ints) from templates - not needed here since `get_shared_drive_id()`
returns a plain string; you could use
destination_folder_id=get_shared_drive_id_task.output instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
