Dev-iL commented on code in PR #59686:
URL: https://github.com/apache/airflow/pull/59686#discussion_r3283693295
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -548,22 +548,22 @@ def _create_ti_state_update_query_and_update_state(
if session.bind is not None:
query = TI.duration_expression_update(timezone.utcnow(),
query, session.bind)
query = query.values(state=TaskInstanceState.FAILED)
- ti = session.get(TI, ti_id_str)
- if ti is not None:
- _handle_fail_fast_for_dag(ti=ti, dag_id=dag_id,
session=session, dag_bag=dag_bag)
Review Comment:
It looks unintentional 6mo later, but perhaps it was resolving some
flakiness or inconsistency between sqla versions, or deemed unnecessary in
light of the other changes.
The lack of coverage is not the motivation for the removal, but rather the
reason it "succeeded".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
