jbbqqf commented on issue #45512:
URL: https://github.com/apache/airflow/issues/45512#issuecomment-4515866264

   Hi! Triaging older issues — I think this one has effectively been superseded 
and could be closed.
   
   `BigQueryCreateExternalTableOperator` was deprecated and removed from the 
Google provider in favor of the new `BigQueryCreateTableOperator`:
   
   - PR [#46673](https://github.com/apache/airflow/pull/46673) — *"Deprecate 
`BigQueryCreateExternalTableOperator` and `BigQueryCreateEmptyTableOperator` 
and introduce new `BigQueryCreateTableOperator`"* (merged).
   - On current `main`, the class is no longer present in 
[`providers/google/src/airflow/providers/google/cloud/operators/bigquery.py`](https://github.com/apache/airflow/blob/main/providers/google/src/airflow/providers/google/cloud/operators/bigquery.py);
 only `BigQueryCreateTableOperator` (line 1212) remains.
   - The replacement uses `table_resource` (a [BigQuery `Table` REST 
resource](https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#Table))
 where the caller passes a fully-formed table definition. As @EugeneYushin 
noted [in this 
thread](https://github.com/apache/airflow/issues/45512#issuecomment-2584069820),
 schema autodetection in the old operator was tied to a now-deprecated code 
path; the new operator delegates the schema/autodetect contract to the caller 
via `table_resource`, which is consistent with the BigQuery REST API.
   
   If schema discovery via `autodetect=True` is still desired on the new 
`BigQueryCreateTableOperator`, that would probably be a separate, narrower 
feature request against `table_resource.externalDataConfiguration.autodetect`. 
As filed against the deprecated operator, this looks closeable.
   
   Would you mind closing this out? Happy to take a closer look if I missed a 
regression in the new operator.
   
   (Disclosure: I drafted this comment with help from Claude Code while 
triaging stale issues; the references above were verified manually against the 
current `main` branch.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to