o-nikolas commented on code in PR #67254:
URL: https://github.com/apache/airflow/pull/67254#discussion_r3286382697
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -230,6 +233,8 @@ def _execute(self) -> int | None:
capacity=self.capacity,
logger=log,
queues=self.queues,
+ team_name=self.team_name,
+ multi_team=self._multi_team,
Review Comment:
Why do we bother plumbing through the `core.multi_team` config value? Isn't
it easy to look up at any point?
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -180,6 +181,8 @@ def __init__(
else:
raise ValueError(f"Capacity number {capacity!r} is invalid")
self.queues = queues
+ self._multi_team = conf.getboolean("core", "multi_team")
+ self.team_name = team_name if self._multi_team else None
Review Comment:
Why this silent failure? We should either raise here or just trust that the
CLI code is catching this case for us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
