bobu-putheeckal commented on PR #67081: URL: https://github.com/apache/airflow/pull/67081#issuecomment-4523898985
Thanks for working on this. I took a quick look at #43366 and tried a local patch against current `main` to understand where the confusion comes from. One thing I noticed: this PR currently adds YAML comments above the `[metrics]` section, but the generated Configuration Reference appears to render the section and option descriptions from `config.yml`, not plain YAML comments. So I don't think the added comments will show up on the docs page that #43366 is about. A slightly different fix may be more effective: - keep both `[metrics] otel_*` and `[traces] otel_*` options, since they configure separate features - update the rendered `metrics.description` and `traces.description` to explicitly say metrics OpenTelemetry settings configure metric export only, and traces settings configure trace export only - adjust the metrics OpenTelemetry option descriptions that currently mention traces, for example `[metrics] otel_host`, `otel_interval_milliseconds`, and `otel_service` That seems to preserve the point raised in #43366 without repeating the earlier #43389 approach of removing metrics options. Happy to help with a patch if that direction sounds useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
