Shrividya commented on code in PR #67360:
URL: https://github.com/apache/airflow/pull/67360#discussion_r3293286457
##########
providers/dbt/cloud/tests/unit/dbt/cloud/operators/test_dbt.py:
##########
@@ -180,6 +180,58 @@ def test_execute_failed_before_getting_deferred(
dbt_op.execute(MagicMock())
assert not mock_defer.called
+ @patch(
+
"airflow.providers.dbt.cloud.hooks.dbt.DbtCloudHook.get_job_run_status",
+ return_value=DbtCloudJobRunStatus.QUEUED.value,
+ )
+
@patch("airflow.providers.dbt.cloud.operators.dbt.DbtCloudRunJobOperator.defer")
+ @patch("airflow.providers.dbt.cloud.operators.dbt.DbtCloudRunJobTrigger")
+ @patch("airflow.providers.dbt.cloud.hooks.dbt.DbtCloudHook.get_connection")
+ @patch(
+ "airflow.providers.dbt.cloud.hooks.dbt.DbtCloudHook.trigger_job_run",
+ return_value=mock_response_json(DEFAULT_ACCOUNT_JOB_RUN_RESPONSE),
+ )
+ def test_execute_deferrable_does_not_pass_execution_timeout_to_defer(
+ self,
+ mock_trigger_job_run,
+ mock_dbt_hook,
+ mock_dbt_trigger,
+ mock_defer,
+ mock_job_run_status,
+ ):
+ dbt_op = DbtCloudRunJobOperator(
+ dbt_cloud_conn_id=ACCOUNT_ID_CONN,
+ task_id=TASK_ID,
+ job_id=JOB_ID,
+ check_interval=1,
+ timeout=3,
+ dag=self.dag,
+ deferrable=True,
+ execution_timeout=timedelta(seconds=3),
Review Comment:
I understand. The addition of test case was suggested more of about
documenting the default behavior explicitly in the test suite, but I'll leave
it to your discretion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
