SameerMesiah97 commented on code in PR #67382:
URL: https://github.com/apache/airflow/pull/67382#discussion_r3294205756
##########
providers/airbyte/src/airflow/providers/airbyte/operators/airbyte.py:
##########
@@ -111,7 +111,7 @@ def execute(self, context: Context) -> None:
self.log.debug("Running in deferrable mode in job state %s...",
state)
if state in (JobStatusEnum.RUNNING, JobStatusEnum.PENDING,
JobStatusEnum.INCOMPLETE):
self.defer(
- timeout=self.execution_timeout,
Review Comment:
@henry3260
I agree. This is a very valid edge case but this PR was submitted on short
notice to fix a resource leak before an RC2 can be cut for the airbyte
provider. For the fix in this PR to land in RC2, it has to be merged by
2026-05-26 so the scope is purposely being kept very tight so that even a
generalist reviewer can confidently sign off on it. I believe it might be
better for me to open another PR to address your comment. If you disagree with
my reasoning, you are free to express yourself here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
