potiuk commented on PR #56973: URL: https://github.com/apache/airflow/pull/56973#issuecomment-4529953790
@hwang-cadent Thanks for the work on this PR and for addressing two of the points from my March review — using the `is None` identity check, and separating the `serialized_objects.py` fix into its own change. I'm closing this for now to keep the queue clear after ~7 months of iteration, but please feel free to reopen (or open a fresh PR) once the remaining two points are addressed: 1. **Architecture intent (concern #1):** confirm that `XCOM_DAG_ID` is pushed from `task_runner.py` alongside `XCOM_RUN_ID` (not from inside the operator before the `DagRunTriggerException` raise path), so failure-mode state stays consistent across both XComs. 2. **Test-call ordering (concern #4):** restore the ordered call verification in `test_trigger_dagrun.py` where it was replaced with `assert_any_call`. The ordering guarantee is worth keeping. There's no rush — when you reopen with those addressed, please ping me and I'll re-review promptly. --- _Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._ --- Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
