[
https://issues.apache.org/jira/browse/AIRFLOW-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005068#comment-17005068
]
ASF GitHub Bot commented on AIRFLOW-6397:
-----------------------------------------
dstandish commented on pull request #6958: [AIRFLOW-6397] ensure sub_process
attribute exists before trying to kil
URL: https://github.com/apache/airflow/pull/6958
in bash operator, `sub_process` attribute is not created in `__init__`
and if `on_kill` is called before sub_process is created, we'll get an
exception
this was causing flakey failures in the jobs test
`test_mark_success_no_kill`
this change creates attribute in init, and in `on_kill`, checks that it has
been assigned a value before trying to kill
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Check for `sub_process` before trying to get pid in bash operator on kill
> -------------------------------------------------------------------------
>
> Key: AIRFLOW-6397
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6397
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.7
> Reporter: Daniel Standish
> Assignee: Daniel Standish
> Priority: Major
>
> test {{test_mark_success_no_kill}} in {{TestLocalTaskJob}} is very flakey
> i found that one reason is that the test may attempt to kill the task before
> the subprocess is created and stored as an attribute
> For example:
> {code}
> [2019-12-29 15:03:51,963] {bash_operator.py:116} INFO - Running command:
> sleep 600
> [2019-12-29 15:03:51,967] {helpers.py:315} INFO - Sending Signals.SIGTERM to
> GPID 57093
> [2019-12-29 15:03:51,968] {taskinstance.py:913} ERROR - Received SIGTERM.
> Terminating subprocesses.
> [2019-12-29 15:03:51,970] {bash_operator.py:143} INFO - Sending SIGTERM
> signal to bash process group
> [2019-12-29 15:03:51,970] {taskinstance.py:913} ERROR - Received SIGTERM.
> Terminating subprocesses.
> [2019-12-29 15:03:51,982] {bash_operator.py:143} INFO - Sending SIGTERM
> signal to bash process group
> [2019-12-29 15:03:51,982] {taskinstance.py:1078} ERROR - 'BashOperator'
> object has no attribute 'sub_process'
> Traceback (most recent call last):
> File "/Users/dstandish/code/airflow/airflow/models/taskinstance.py", line
> 945, in _run_raw_task
> result = task_copy.execute(context=context)
> File "/Users/dstandish/code/airflow/airflow/operators/bash_operator.py",
> line 123, in execute
> preexec_fn=pre_exec)
> File "/Users/dstandish/.pyenv/versions/3.7.5/lib/python3.7/subprocess.py",
> line 800, in __init__
> restore_signals, start_new_session)
> File "/Users/dstandish/.pyenv/versions/3.7.5/lib/python3.7/subprocess.py",
> line 1505, in _execute_child
> part = os.read(errpipe_read, 50000)
> File "/Users/dstandish/code/airflow/airflow/models/taskinstance.py", line
> 914, in signal_handler
> task_copy.on_kill()
> File "/Users/dstandish/code/airflow/airflow/operators/bash_operator.py",
> line 144, in on_kill
> os.killpg(os.getpgid(self.sub_process.pid), signal.SIGTERM)
> AttributeError: 'BashOperator' object has no attribute 'sub_process'
> [2019-12-29 15:03:51,988] {taskinstance.py:1123} INFO - Marking task as
> FAILED.dag_id=test_mark_success, task_id=task1,
> execution_date=20160101T000000, start_date=20191229T230351,
> end_date=20191229T230351
> [2019-12-29 15:03:52,022] {helpers.py:281} INFO - Process
> psutil.Process(pid=57093, status='terminated') (57093) terminated with exit
> code 1
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
