justinmclean commented on code in PR #213:
URL: https://github.com/apache/airflow-steward/pull/213#discussion_r3295872448
##########
tools/skill-validator/src/skill_validator/__init__.py:
##########
@@ -80,6 +80,11 @@
"apache.org/airflow",
]
+# Paths exempt from security-pattern checks because they intentionally show
+# "do not do this" examples (e.g. the security checklist itself documents the
+# bad patterns so reviewers can recognise them).
+SECURITY_PATTERN_SKIP_PATHS: tuple[str, ...] =
("write-skill/security-checklist.md",)
Review Comment:
Rejecting this. skill-validator is an internal dev/CI tool that only runs on
Linux and macOS — Windows isn't a supported platform, so the str(path)
backslash case can't arise.
On the endswith/exact-match suggestion: SECURITY_PATTERN_SKIP_PATHS is a
small, fixed tuple of known internal paths, not user input, so this isn't a
realistic concern. Not worth the added complexity here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
