amoghrajesh commented on code in PR #67455:
URL: https://github.com/apache/airflow/pull/67455#discussion_r3296528960
##########
airflow-core/tests/integration/otel/test_otel.py:
##########
@@ -358,15 +358,23 @@ def dag_execution_for_testing_metrics(self, capfd):
# Terminate the processes.
scheduler_process.terminate()
- scheduler_process.wait()
+ try:
+ scheduler_process.wait(timeout=30)
+ except subprocess.TimeoutExpired:
+ scheduler_process.kill()
+ scheduler_process.wait()
Review Comment:
This block is repeated couple times, maybe extract it to a
`_terminate_process(proc, timeout=30)` to collapse 12 lines of try/except into
one call per process
##########
airflow-core/tests/integration/otel/test_otel.py:
##########
@@ -387,7 +395,7 @@ def _get_ti(self, dag_id: str, run_id: str, task_id: str)
-> Any | None:
)
return ti
- @pytest.mark.execution_timeout(90)
+ @pytest.mark.execution_timeout(160)
Review Comment:
The budget comment lives in PR desc right now, consider adding a comment
inline to make it self explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
