vincbeck commented on PR #67248: URL: https://github.com/apache/airflow/pull/67248#issuecomment-4535623264
> > From [AIP-103](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-103%3A+Task+State+Management) I understood this new task state management could be used across multiple different use cases such as [intra-task progress checkpointing ](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=406623137#AIP103:TaskStateManagement-Pattern3:Intra-TaskProgressCheckpointing). If that's the case, I am not sure about the name `AssetState`, it feels like something specific to asset although it should be agnostic. What do you think? > > AIP-103 addresses both Task and Asset state. Here are some of the PR's that have added Asset State. > > * [AIP-103: Add Core API endpoints for task state and asset state #67041](https://github.com/apache/airflow/pull/67041) > * [AIP-103: Add Execution API endpoints for task and asset states #66073](https://github.com/apache/airflow/pull/66073) > * [AIP-103: Refactor asset state routes to by-name/by-uri and add AssetUriRef support #66336](https://github.com/apache/airflow/pull/66336) > > cc: @amoghrajesh The APIs look good to me, I am only questioning the way to access the state. In your example you do `asset_state = AssetState(name="generic_asset")`, but in reality the task instance/asset state is scoped to its task instance/asset. It feels weird to me to be able to specify the asset name. If I do `asset_state = AssetState(name="another_asset")`, would I get the state from this other asset even though my code s not scoped to `another_asset`? Would it be protected by a JWT? In my mental model I was expecting a getter and setter like `set_state`, `get_state` that would use the runtime context (task instance ID/asset name) to retrieve the state -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
