o-nikolas commented on code in PR #67217:
URL: https://github.com/apache/airflow/pull/67217#discussion_r3300184025
##########
airflow-core/src/airflow/dag_processing/bundles/base.py:
##########
@@ -304,10 +304,12 @@ def __init__(
name: str,
refresh_interval: int = conf.getint("dag_processor",
"refresh_interval"),
version: str | None = None,
+ version_data: dict[str, Any] | None = None,
Review Comment:
Sure, will do!
##########
airflow-core/src/airflow/executors/workloads/types.py:
##########
@@ -41,6 +41,4 @@
def state_class_for_key(key: WorkloadKey) -> type[TaskInstanceState] |
type[CallbackState]:
if isinstance(key, TaskInstanceKey):
return TaskInstanceState
- if isinstance(key, CallbackKey):
- return CallbackState
- raise TypeError(f"Unknown workload key type: {type(key)!r}")
+ return CallbackState
Review Comment:
There was a bad merge to main that was making this PR (and others) fail,
this was fixing that, but another PR has been merged since fixing it. So this
piece is likely no longer needed. I'll double check and remove it, if so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
