potiuk commented on a change in pull request #6950: [AIRFLOW-6392] Remove
cyclic dependency baseoperator <-> helpers
URL: https://github.com/apache/airflow/pull/6950#discussion_r361908129
##########
File path: airflow/utils/helpers.py
##########
@@ -142,83 +135,6 @@ def as_flattened_list(iterable):
return [e for i in iterable for e in i]
-def chain(*tasks):
Review comment:
I agree it's a bit sad (that's why I added UPDATING.md) but we already have
a number of incompatibilities and we plan to have a migration tool to handle
this https://issues.apache.org/jira/browse/AIRFLOW-6390 (and such automated
conversion will be easy to add).
There are other functions that look useful - validate_key, reduce_in_chunks,
as_tuple, as_flattened_list. I see them as being used by the users - they are
not base-operator dependent but still useful either in custom operators or
dags.
I could of course move the other methods elsewhere, but I think there is an
advantage of moving it (and any future similar methods) to BaseOperator.
I wonder what others think about it ? Is it worth to introduce such
incompatibility or not?
I am happy to do both but I think it's quite a bit cleaner as it is now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
