nathadfield commented on issue #67541:
URL: https://github.com/apache/airflow/issues/67541#issuecomment-4543064291
Correction to the issue body: the **Group / Mapped Header stats rows are NOT
affected**. Both Header files (`pages/GroupTaskInstance/Header.tsx:35-40` and
`pages/MappedTaskInstance/Header.tsx:37-43`) lowercase the key via
`.toLowerCase()` before translating
(\`translate(\`states.\${taskState.toLowerCase()}\`)\`), so \`"None"\` becomes
\`"none"\` and \`common:states.none\` already exists in
\`airflow-core/src/airflow/ui/public/i18n/locales/en/common.json:231\` ("No
Status"). The Header stats render correctly today.
The remaining (genuine) affected sites are:
1.
\`airflow-core/src/airflow/ui/src/components/Graph/SegmentedStateBar.tsx:44\` —
\`bg={\`\${state}.solid\`}\` is **not** lowercased and \`"None.solid"\` has no
Chakra theme token, so the no-status slice renders without a colour.
2.
\`airflow-core/src/airflow/ui/src/components/TaskInstanceTooltip.tsx:143-156\`
— both the swatch (\`bg={\`\${state}.solid\`}\`, tokenless) **and** the label
(\`translate(\`common:states.\${state}\`)\`, no \`.toLowerCase()\` applied)
render the raw \`"None"\` key.
The "Acceptance criteria" section should be read with one bullet dropped:
> ~~Group / Mapped Header stats row for no-status children uses the "No
status" label, not \`states.None\`.~~
The Header bullet was based on a faulty audit step on my side. Apologies for
the noise.
---
Drafted-by: Claude Code (Opus 4.7); reviewed by @nathadfield before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
