potiuk commented on a change in pull request #6955: [AIRFLOW-6394] Simplify github PR template URL: https://github.com/apache/airflow/pull/6955#discussion_r361914198
########## File path: .github/PULL_REQUEST_TEMPLATE.md ########## @@ -1,33 +1,5 @@ -Make sure you have checked _all_ steps below. - -### Jira - -- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR" - - https://issues.apache.org/jira/browse/AIRFLOW-XXX - - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue. - - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)). Review comment: I added information (not a tick-mark) about AIP. That's useful. The rest is just redundant with "Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or `[AIRFLOW-XXXX]` for document-only changes" I think. One of the goals of that change was to fit every description in one line of github comment and to fit everything in the default size of the PR description box. It's pretty much guaranteed it will not be read if it's longer/multi-line and we can always explain it during review process if someone did not understand it (plus we have very nice description in CONTRIBUTING.md that we can refer people to). I actually added a line with link to contributing now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
